Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatically add fs group when using pvc #1404

Merged
merged 9 commits into from
Jul 31, 2024
Merged

feat: automatically add fs group when using pvc #1404

merged 9 commits into from
Jul 31, 2024

Conversation

KyriosGN0
Copy link
Contributor

No need to manually set the fsGroup when using a PVC for cache

viceice
viceice requested changes Jun 1, 2024
View reviewed changes
charts/renovate/Chart.yaml Outdated Show resolved Hide resolved
charts/renovate/templates/cronjob.yaml Outdated Show resolved Hide resolved
@viceice viceice changed the title Feat automatically add fs group when using pvc feat: automatically add fs group when using pvc Jun 1, 2024
@KyriosGN0
revert chart version
bfc3324 
Signed-off-by: Aviv Guiser <[email protected]>
@KyriosGN0
Copy link
Contributor Author

Hi @viceice could you please clarify your comments?

@KyriosGN0 KyriosGN0 requested a review from viceice June 12, 2024 08:52
@KyriosGN0
fix cronjob.yaml
df91656 
Signed-off-by: Aviv Guiser <[email protected]>
@KyriosGN0 KyriosGN0 requested a review from viceice June 12, 2024 14:24
@KyriosGN0
Copy link
Contributor Author

Hey @viceice
Could you please see if I have missed anything again?
Thanks in advance

viceice
viceice reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to verify this, can merge it earliest on next week

charts/renovate/templates/cronjob.yaml Show resolved Hide resolved
@viceice viceice self-requested a review June 18, 2024 15:37
@KyriosGN0
Copy link
Contributor Author

hey @viceice, any updates here?

@viceice viceice enabled auto-merge July 23, 2024 07:52
auto-merge was automatically disabled July 23, 2024 08:08

Head branch was pushed to by a user without write access

@viceice viceice added this pull request to the merge queue Jul 31, 2024
Merged via the queue into renovatebot:main with commit 870d41f Jul 31, 2024
13 checks passed
@KyriosGN0 KyriosGN0 deleted the feat-automatically-add-fsGroup-when-using-pvc branch July 31, 2024 14:34
@minijus
Copy link

minijus commented Aug 27, 2024

Forced fsGroup when using cache breaks Renovate deployments in restricted environments (e.g. on OpenShift).
@viceice would adding additional option compatability.omitSecurityContextFsGroup be a reasonable way to resolve this issue?

@viceice
Copy link
Member

viceice commented Aug 27, 2024

please open a new discussion and provide more context

@minijus minijus mentioned this pull request Aug 28, 2024
Open
@minijus
Copy link

minijus commented Sep 6, 2024

please open a new discussion and provide more context

@viceice would you be able to have at this issue #1701 ?

I would be happy to submit a PR after some suggestion/agreement how the solution could look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@elektro-wolle elektro-wolle elektro-wolle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KyriosGN0 @minijus @viceice @elektro-wolle