Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ike ascen #1827

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Ike ascen #1827

merged 2 commits into from
Sep 12, 2024

Conversation

jmuessel
Copy link
Contributor

@jmuessel jmuessel commented Sep 12, 2024

Purpose of this PR

Introduce a new scenario for the IKEA project: gdp_SSP2_demDiffer_IKEA

This PR corresponds to a PR in mrremind and one in edgeT, where these two scenarios are included now as well.

This PR compliments also the PR, where demand scaling for industry and building is implemented

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@jmuessel jmuessel merged commit fe045b9 into remindmodel:develop Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants