Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move enhanced weathering data to mrremind #1486

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Move enhanced weathering data to mrremind #1486

merged 4 commits into from
Dec 12, 2023

Conversation

katarkow
Copy link
Contributor

@katarkow katarkow commented Nov 30, 2023 •
edited
Loading

Purpose of this PR

Moving the hardcoded values of enhanced weathering costs to mrremind. Here is the corresponding mrrremind PR.

This fixes #1479.

The parameter looks as follows after the file is read into REMIND.
p33_EW_transport_cost

Type of change

  • Bug fix
  • Refactoring
  • Minor change

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • I created the new input data

@katarkow katarkow marked this pull request as ready for review November 30, 2023 15:57
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs new input data revision.

@katarkow
Copy link
Contributor Author

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q, @LaviniaBaumstark, I created the input data 6.607 and updated the input revision. Can you re-review?

@katarkow katarkow merged commit 01b0dec into remindmodel:develop Dec 12, 2023
2 checks passed
@katarkow katarkow deleted the migrate_EW_data_to_mrremind branch December 12, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q approved these changes

@strefler strefler Awaiting requested review from strefler

@LaviniaBaumstark LaviniaBaumstark Awaiting requested review from LaviniaBaumstark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MR #1154 broke REMIND EU21
3 participants
@katarkow @LaviniaBaumstark @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q