Nombre de archivos y funciones nuevas #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perdón por la demora, justo estoy terminando mi proyecto de GSoC2014 y no pude verlo en detalle. En principio coincido en que hace falta el renombramiento, pero creo que se puede simplificar y unificar aún más para tener más consistencia:
¿Opiniones? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corregí los nombres de los archivos para que sea más claro.
También saqué los caracteres no ascii en los mensajes, porque daba errores en el envío por ajax.
Agregué la función getSubtotal, getErrors y getPrinterId
La funcion getPrinterVersion está comentada porque solo sirve para la 320
Agregué la posibilidad de poner datos de impresion de header al crear una factura.