Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.parseContent() bug fix #103

Closed
wants to merge 8 commits into from
Closed

Conversation

lodev09
Copy link
Contributor

@lodev09 lodev09 commented Sep 16, 2014

Code below will result to an endless execution of onPreview hook when .parseContent() is used inside the hook.

callbackContent = this.$options.onPreview(this) // Try to get the content from callback

See code comments...

serkanalgur and others added 8 commits September 16, 2014 16:39
Turkish translation file added and missed code, ordred list, save, quote
texts added to translation
Fixed a bug from parseContent method when used inside onPreview hook.

Added an optional argument val for some reason :)
@toopay
Copy link
Member

toopay commented Sep 25, 2014

Hey @lodev09, it seems your fork is not longer synced with master. I assume your patch is only lodev09@9e865ea , yes ?

@lodev09
Copy link
Contributor Author

lodev09 commented Sep 25, 2014

@toopay yes correct

@nud
Copy link

nud commented Oct 28, 2014

Also have a look at pull request #116, it also solves this issue with a slightly different goal.

toopay added a commit that referenced this pull request Jan 7, 2015
@toopay toopay closed this Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants