chore(server-store): Alias imports for getting request details to @redwoodjs/web/request
#10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
commented
Jul 2, 2024
| @@ -37,6 +37,11 @@ | |||
| "types": "./dist/components/ServerInject.d.ts", | |||
| "default": "./dist/components/ServerInject.js" | |||
| }, | |||
| "./request": { | |||
| "require": "./dist/cjs/server/request.js", | |||
There was a problem hiding this comment.
We need this so that typescript doesn't complain in projects, but in reality the CJS version should never be used.
|
Pausing this. Discussing with Tobbe about naming options |
…rt-serverStore * 'main' of github.com:redwoodjs/redwood: chore(comment): Remove comment that's wrong (redwoodjs#10912) chore(esm): Fix project-config dual packaging (redwoodjs#10901) RSC: dbAuth in kitchen-sink (redwoodjs#10907) RSC: No need to pass location to Router anymore (redwoodjs#10905) RSC: Make `rw g page` work for RSC projects (redwoodjs#10903) Updates document template to use exports field for htmlTags (redwoodjs#10902)
… into feat/re-export-serverStore * 'feat/re-export-serverStore' of github.com:dac09/redwood:
|
Discussed and agreed with Tobbe to keep this convention, we can adjust the export name i.e. |
auto-merge was automatically disabled
July 5, 2024 19:56
Pull Request is not mergeable
dac09
pushed a commit
to dac09/redwood
that referenced
this pull request
Jul 6, 2024
…iddleware * 'main' of github.com:redwoodjs/redwood: chore(server-store): Alias imports for getting request details to `@redwoodjs/web/request` (redwoodjs#10904) chore(ci): Cleaner log when publishing, unless failure (redwoodjs#10919) chore(tests): Fix failing kitchen-sink tests by logging in (redwoodjs#10920) fix(internal gql): Update types in test fixture (redwoodjs#10918) debug(ci): Print publishing command output (redwoodjs#10916) chore(ci): Use more supported syntax in publish_canary script (redwoodjs#10915) chore(ci): Exit canary publishing if version cannot be determined (redwoodjs#10914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to import their request details from a logical path:
I think this makes much more sense than server-store, which is an internal implementation detail.
Note: I noticed that we're not getting request headers and request cookies when I try to print them on screen
The behaviour here doesn't seem related to the changes in the PR, as it's the same if I directly import from
@redwoodjs/server-store.