Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding En dash rule #699

Closed
wants to merge 1 commit into from
Closed

Adding En dash rule #699

wants to merge 1 commit into from

Conversation

aireilly
Copy link
Member

@aireilly aireilly commented Dec 12, 2023 •
edited
Loading

Fixes #698

Generally, use an en dash (–) without spaces on each side to indicate a range of numbers. If you list numbers along with other characters, unless the context determines a different order of the characters, list numeric characters first, followed by alphabetic characters (uppercase and then lowercase), followed by other characters in ASCII order.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-699.surge.sh 🎊

@aireilly aireilly changed the title adding en dash rule [WIP] adding en dash rule Dec 12, 2023
@aireilly aireilly force-pushed the en-dashes branch 11 times, most recently from f2f2baf to 8b2331a Compare December 15, 2023 13:00
@aireilly aireilly force-pushed the en-dashes branch 3 times, most recently from 2121b7f to 0b6006c Compare January 2, 2024 17:19
@aireilly aireilly changed the title [WIP] adding en dash rule Adding en dash rule Jan 2, 2024
@aireilly aireilly force-pushed the en-dashes branch 3 times, most recently from d5be035 to d51c0ce Compare July 24, 2024 15:11
@aireilly
Copy link
Member Author

This is now ready for review - the new Vale back reference feature is very useful.

@redhat-documentation redhat-documentation deleted a comment from github-actions bot Jul 24, 2024
@aireilly aireilly force-pushed the en-dashes branch 3 times, most recently from 143ddd1 to 8af4e1f Compare July 24, 2024 15:13
@aireilly aireilly requested a review from apinnick September 13, 2024 10:16
apinnick
apinnick approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@apinnick apinnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a query about the "page" title, LGTM.

modules/reference-guide/pages/endashes.adoc Outdated Show resolved Hide resolved
@aireilly aireilly force-pushed the en-dashes branch 2 times, most recently from 24a2d4e to 853fe7f Compare September 16, 2024 09:56
@aireilly aireilly force-pushed the en-dashes branch 2 times, most recently from ff96bbc to 17ba453 Compare September 16, 2024 10:13
@aireilly aireilly changed the title Adding en dash rule Adding En dash rule Sep 16, 2024
@aireilly
Copy link
Member Author

In retrospect, I am going to close this un-merged. Terms like the below perfectly valid and will get caught in this rule.

ip-10-0-0-1.us-east-2.compute.internal
775898c3-ecc2-41a4-b98b-a4cd5ae56fd0
2023-09-22

@aireilly aireilly closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apinnick apinnick apinnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a number ranges rule
2 participants
@aireilly @apinnick