Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosted-control-planes-518 #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hosted-control-planes-518 #520

wants to merge 1 commit into from

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Oct 9, 2024 •
edited
Loading

@dfitzmau dfitzmau force-pushed the hosted-contol-planes-518 branch 4 times, most recently from 84f81a5 to df26e66 Compare October 9, 2024 15:10
lahinson
lahinson previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau Many thanks for creating this PR! I made a couple of suggestions in the entry for "hosted control planes". Otherwise, this LGTM.

supplementary_style_guide/glossary_terms_conventions/general_conventions/h.adoc Outdated Show resolved Hide resolved
@dfitzmau dfitzmau force-pushed the hosted-contol-planes-518 branch from df26e66 to 8878705 Compare October 14, 2024 15:57
@dfitzmau dfitzmau changed the title [WIP] hosted-control-planes-518 hosted-control-planes-518 Oct 25, 2024
@dfitzmau dfitzmau force-pushed the hosted-contol-planes-518 branch from 8878705 to 244cadc Compare October 25, 2024 09:14
ndeevy
ndeevy approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ndeevy ndeevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @dfitzmau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeevy ndeevy ndeevy approved these changes

@lahinson lahinson lahinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfitzmau @ndeevy @lahinson