-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 483, change identity provider acronym from IDP to IdP to match established usage #508
Conversation
…established usage
supplementary_style_guide/glossary_terms_conventions/general_conventions/i.adoc
Show resolved
Hide resolved
Open a new issue for vale updates.
…On Wed, Jul 31, 2024 at 4:58 AM Darragh Fitzmaurice < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
supplementary_style_guide/glossary_terms_conventions/general_conventions/i.adoc
<#508 (comment)>
:
> @@ -174,7 +174,7 @@ Capitalize it only when it starts a sentence.
[[identity-provider-federation]]
==== image:images/yes.png[yes] identity provider federation (noun)
-*Description*: In Red{nbsp}Hat Single Sign-On, you can delegate authentication to one or more IDPs, and this process is referred to as _identity provider federation_. Social login through Facebook or Google+ is an example of identity provider federation. You can also hook Red{nbsp}Hat Single Sign-On to delegate authentication to any other OpenID Connect or SAML 2.0 IDP.
+*Description*: In Red{nbsp}Hat Single Sign-On, you can delegate authentication to one or more IdPs, and this process is referred to as _identity provider federation_. Social login through Facebook or Google+ is an example of identity provider federation. You can also hook Red{nbsp}Hat Single Sign-On to delegate authentication to any other OpenID Connect or SAML 2.0 IdP.
To stop the Vale issue flagging in the RH SSG repo, update the
https://github.com/aireilly/supplementary-style-guide/blob/main/.vale/styles/config/vocabularies/SSG/accept.txt#L70
and remove the IDP entry.
Aidan raised a higher-level Vale update with
redhat-documentation/vale-at-red-hat#850
<redhat-documentation/vale-at-red-hat#850> but
this issue would require a bit of work as all terms need to be analyzed for
input into the Vale project.
—
Reply to this email directly, view it on GitHub
<#508 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALF2CY2KHK2KPGG2VKL5TYDZPCRJLAVCNFSM6AAAAABLW4JDVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBZGU4DCNRQHE>
.
You are receiving this because you authored the thread.Message ID:
<redhat-documentation/supplementary-style-guide/pull/508/review/2209581609
@github.com>
--
Spank McCoy
He/Him/His
Principal Technical Writer
Red Hat <https://www.redhat.com>
***@***.***
M: +1-919-426-4654
<https://red.ht/sig>
|
Thanks. Please open a new issue to address this Vale prompt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dfitzmau it's not necessarily on the SSG team to know whether there are any Vale updates that need to be made with these updates. We assume that the Vale team regularly reviews SSG updates (which we post to the what's new section) to make updates as necessary.
@aireilly etc please let me know if this is not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is accurate, however the updates are usually sporadic and "reactive" to issues as they occur. It would be good to formalize this process. I will take an action to review and formalize the update process. Edit: Created redhat-documentation/vale-at-red-hat#855 to track the Vale update process |
supplementary_style_guide/glossary_terms_conventions/general_conventions/i.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3 approvals. Merging |
…established usage
Issue 483, change identity provider acronym from IDP to IdP to match …
Issue:
#483
Additional information: