Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add verify changesets step #65

Merged
merged 3 commits into from
Nov 22, 2024
Merged

chore(ci): add verify changesets step #65

merged 3 commits into from
Nov 22, 2024

Conversation

04kash
Copy link
Collaborator

@04kash 04kash commented Nov 22, 2024 •
edited
Loading

Hey, I just made a Pull Request!

This PR adds a Verify Changesets step to the ci workflow.

FIxes: https://issues.redhat.com/browse/RHIDP-5033

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@04kash
exclude noop from verify changesets
cf602ca 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash
add fetch-depth: 0
ee39d87 
Signed-off-by: Kashish Mittal <[email protected]>
christoph-jerolimov
christoph-jerolimov approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

I think we should merge it to verify it once with a PR without a changeset.

@04kash 04kash merged commit 0a733a2 into redhat-developer:main Nov 22, 2024
16 checks passed
04kash added a commit that referenced this pull request Nov 22, 2024
@04kash
Revert "chore(ci): add verify changesets step (#65)"
6af2428 
This reverts commit 0a733a2.
@04kash 04kash mentioned this pull request Nov 22, 2024
Merged
04kash added a commit that referenced this pull request Nov 22, 2024
@04kash
Revert "chore(ci): add verify changesets step (#65)" (#69)
373c36e 
This reverts commit 0a733a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar karthikjeeyar is a code owner

@yangcao77 yangcao77 Awaiting requested review from yangcao77 yangcao77 is a code owner

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03 rohitkrai03 is a code owner

@ciiay ciiay Awaiting requested review from ciiay ciiay is a code owner

@debsmita1 debsmita1 Awaiting requested review from debsmita1 debsmita1 is a code owner

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta divyanshiGupta is a code owner

@rm3l rm3l Awaiting requested review from rm3l rm3l is a code owner

@BethGriggs BethGriggs Awaiting requested review from BethGriggs BethGriggs is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner

@kim-tsao kim-tsao Awaiting requested review from kim-tsao kim-tsao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@04kash @christoph-jerolimov