Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate orchestrator plugin #57

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Migrate orchestrator plugin #57

merged 12 commits into from
Nov 25, 2024
+73,868 −1

Conversation

batzionb
Copy link
Contributor

migration of orchestrator plugins from https://github.com/janus-idp/backstage-plugins, base on commit:
janus-idp/backstage-plugins@86c7c1b

@batzionb
Copy link
Contributor Author

@BethGriggs
Can you please approve the workflow to get the CI running?

@batzionb batzionb force-pushed the migrate-orchestrator branch from 8917d71 to 9afc8e9 Compare November 20, 2024 12:29
@batzionb
Copy link
Contributor Author

@BethGriggs
Can you approve the workflow again please?

@batzionb batzionb force-pushed the migrate-orchestrator branch from 9afc8e9 to 31e709d Compare November 20, 2024 13:17
04kash
04kash reviewed Nov 20, 2024
View reviewed changes
workspaces/orchestrator/plugins/orchestrator-backend/package.json Outdated Show resolved Hide resolved
workspaces/orchestrator/app-config.yaml Outdated Show resolved Hide resolved
workspaces/orchestrator/package.json Outdated Show resolved Hide resolved
workspaces/orchestrator/plugins/orchestrator-backend/package.json Outdated
"@backstage/plugin-permission-node": "^0.8.4",
"@backstage/plugin-scaffolder-backend": "^1.26.2",
"@backstage/plugin-scaffolder-node": "^0.5.0",
"@red-hat-developer-hub/backstage-plugin-orchestrator-common": "^1.24.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@red-hat-developer-hub/backstage-plugin-orchestrator-common": "^1.24.0",
"@red-hat-developer-hub/backstage-plugin-orchestrator-common": "workspace:^",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Nov 20, 2024 •
edited
Loading

Hi, you should also add some a code owners to .github/CODEOWNERS

To solve the current CI issue, you should run yarn tsc && yarn build:api-reports:only from the workspace to generate some API reports.

@batzionb
Copy link
Contributor Author

@BethGriggs @christoph-jerolimov
Any idea how to fix "yarn backstage-cli repo fix --check --publish" is failing?
I tried "yarn fix"
And "yarn backstage-cli repo fix" and it doens't seem to have any impact

@batzionb
Copy link
Contributor Author

@BethGriggs @christoph-jerolimov Any idea how to fix "yarn backstage-cli repo fix --check --publish" is failing? I tried "yarn fix" And "yarn backstage-cli repo fix" and it doens't seem to have any impact

OK figured it out I needed to run
yarn backstage-cli repo fix --publish

@batzionb
Copy link
Contributor Author

CI passed :)

@BethGriggs can you please approve?

BethGriggs
BethGriggs approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed every file in depth. But, CI is passing, and migration steps and all package.json files look correct.

@BethGriggs BethGriggs merged commit 54daa8c into redhat-developer:main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04kash 04kash 04kash left review comments

@BethGriggs BethGriggs BethGriggs approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner

@kim-tsao kim-tsao Awaiting requested review from kim-tsao kim-tsao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@batzionb @christoph-jerolimov @BethGriggs @04kash