Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHIDP-2921: Initial version of a marketplace plugin #47

Merged
merged 5 commits into from
Nov 18, 2024
Merged

RHIDP-2921: Initial version of a marketplace plugin #47

merged 5 commits into from
Nov 18, 2024

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 18, 2024 •
edited
Loading

Hey, I just made a Pull Request!

https://issues.redhat.com/browse/RHIDP-2921

Just an first version of marketplace types and frontend -> backend communication.

  • MUI v5
  • React query
  • Types in common lib
  • Backend that returns some mock data (next step is to load them from the file system)
  • Frontend that loads the mock data and shows them in a grid (with a ugly filter input field for now)

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@christoph-jerolimov christoph-jerolimov self-assigned this Nov 18, 2024
@christoph-jerolimov christoph-jerolimov changed the title feat(marketplace): initial version of a marketplace api feat(marketplace): initial version of a marketplace workspace/plugin Nov 18, 2024
@christoph-jerolimov christoph-jerolimov changed the title feat(marketplace): initial version of a marketplace workspace/plugin feat(marketplace): initial version of a marketplace plugin Nov 18, 2024
@christoph-jerolimov christoph-jerolimov changed the title feat(marketplace): initial version of a marketplace plugin RHIDP-2921: Initial version of a marketplace plugin Nov 18, 2024
divyanshiGupta
divyanshiGupta approved these changes Nov 18, 2024
View reviewed changes
Copy link

@divyanshiGupta divyanshiGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 18, 2024
@christoph-jerolimov christoph-jerolimov merged commit c241be9 into redhat-developer:main Nov 18, 2024
6 checks passed
@christoph-jerolimov christoph-jerolimov deleted the kickoff-marketplace branch November 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshiGupta divyanshiGupta divyanshiGupta approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1 debsmita1 is a code owner

@ciiay ciiay Awaiting requested review from ciiay

Assignees

@christoph-jerolimov christoph-jerolimov

@divyanshiGupta divyanshiGupta

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christoph-jerolimov @divyanshiGupta