Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dynamic-home-page plugin from showcase #39

Merged

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 16, 2024

Hey, I just made a Pull Request!

  1. Renamed workspace to homepage to make it possible to add other plugins/features in the future.
  2. Migrated the actual code from janus-idp/backstage-showcase/.../plugins/dynamic-home-page
  3. Addressed linter, prettier and api-export.md issues to align it with this repo rules

This PR would release @red-hat-developer-hub/backstage-plugin-dynamic-home-page as 0.0.1 to create and test a wrapper in showcase. I would increase the version when everything is working.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Copy link

@divyanshiGupta divyanshiGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christoph-jerolimov christoph-jerolimov merged commit 0de827a into redhat-developer:main Nov 18, 2024
6 checks passed
@christoph-jerolimov christoph-jerolimov deleted the kickoff-homepage branch November 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants