plugin(bulk-import): remove canvas from devDependencies #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04kash
requested review from
christoph-jerolimov,
debsmita1,
rm3l,
BethGriggs,
nickboldt and
kim-tsao
as code owners
Signed-off-by: Kashish Mittal <[email protected]>
04kash
force-pushed
the
remove-canvas
branch
from
9d7fdce to
cfd6539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
canvaswas added as a devDependency while migrating the plugin from janus-idp/backstage-plugins. SInce the unit tests pass without the need of this devDependency, it can be removed.I have also updated the migration script so that
canvasisn't automatically added as a devDependency.✔️ Checklist