You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ydayagi
A cleaner way to do the postinstall is to add to
workspaces/orchestrator/plugins/orchestrator-common/package.json to scripts field this:
"postinstall": "openapi:generate"
@ydayagi
I checked out the PR and saw how the orchestrator-api.yaml is generated
Can you add the final file to the source code? Same as all generated files are in the source code
Otherwise after running openapi:generated it appears as a change in the repo (it's not part of .gitignore)
@ydayagi I checked out the PR and saw how the orchestrator-api.yaml is generated Can you add the final file to the source code? Same as all generated files are in the source code Otherwise after running openapi:generated it appears as a change in the repo (it's not part of .gitignore)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ydayagi
requested review from
batzionb,
mareklibra and
gciavarrini
as code owners
FLPATH-1774
https://issues.redhat.com/browse/FLPATH-1774