Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator installation): fix OCP version detection on clusterbot rosa; throw error when umoci is not installed, with installation call to action (RHIDP-5108) #490

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 29, 2024

What does this PR do?

fix(operator installation): fix OCP version detection on clusterbot rosa; throw error when umoci is not installed, with installation call to action (RHIDP-5108)

Signed-off-by: RHDH Build (rhdh-bot) [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-5108

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…osa; throw error when umoci is not installed, with installation call to action

Signed-off-by: RHDH Build (rhdh-bot) <[email protected]>
@nickboldt nickboldt requested a review from rm3l November 29, 2024 22:51
@nickboldt nickboldt changed the title fix(operator installation): fix OCP version... fix(operator installation): fix OCP version detection on clusterbot rosa; throw error when umoci is not installed, with installation call to action (RHIDP-5108) Nov 29, 2024
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c08f96c into main Nov 30, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the RHIDP-5108_part1 branch November 30, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants