Skip to content

Commit

Permalink
Fixed an issue with the JSON text editors caused by them being in scr…
Browse files Browse the repository at this point in the history
…oll panes. Those components have their own scrolling, and the nested scrolling mechanisms were causing issues with keyboard navigation, e.g., page up/down, etc., and other features such a Find (Ctrl+F). Without the surrounding scroll panes, it was also important that they be added so that they fill their available space vertically. (#655)
  • Loading branch information
SCWells72 authored Dec 1, 2024
1 parent dfd27f9 commit 385e170
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,12 @@ private static JLabel createLabelForComponent(@NotNull @NlsContexts.Label String

private void createConfigurationField(FormBuilder builder) {
configurationWidget = new LanguageServerConfigurationWidget(project);
JBScrollPane scrollPane = new JBScrollPane(configurationWidget);
builder.addLabeledComponent(LanguageServerBundle.message("language.server.configuration"), scrollPane, true);
builder.addLabeledComponentFillVertically(LanguageServerBundle.message("language.server.configuration"), configurationWidget);
}

private void createInitializationOptionsTabField(FormBuilder builder) {
initializationOptionsWidget = new LanguageServerInitializationOptionsWidget(project);
JBScrollPane scrollPane = new JBScrollPane(initializationOptionsWidget);
builder.addLabeledComponent(LanguageServerBundle.message("language.server.initializationOptions"), scrollPane, true);
builder.addLabeledComponentFillVertically(LanguageServerBundle.message("language.server.initializationOptions"), initializationOptionsWidget);
}

public JBTextField getServerName() {
Expand Down

0 comments on commit 385e170

Please sign in to comment.