Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use telemetry feedback API (#647) #649

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Dec 14, 2023

Copy link

openshift-ci bot commented Dec 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish changed the title use telemetry feedback API (#647) refactor: use telemetry feedback API (#647) Dec 14, 2023
@sbouchet
Copy link
Collaborator

sbouchet commented Dec 18, 2023

sucessfully tested with local distribution, can see this workload on backend:

Analytics.track("00000000000000", "feedback", new Props()
    .put("app_name", "IntelliJ IDEA Ultimate Edition")
    .put("app_version", "2023.3")
    .put("best", "")
    .put("contact", "")
    .put("extension_name", "OpenShift Toolkit by Red Hat")
    .put("extension_version", "1.8.0-SNAPSHOT")
    .put("frustrating", "")
    .put("java_version", "17.0.9")
    .put("missing", "")
    .put("recommendation", "5")
    .put("recommendation_comment", "")
    .put("result", "success")
    .put("satisfaction", "5")
    .put("satisfaction_comment", "")
    .put("used_similar_extension", "No"

Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
@adietish
Copy link
Contributor Author

adietish commented Jan 8, 2024

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Jan 8, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet
Copy link
Collaborator

sbouchet commented Jan 8, 2024

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Jan 8, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants