Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate build to 2024.2 #801

Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore: migrate build to 2024.2 #801

merged 1 commit into from
Oct 25, 2024

Conversation

sbouchet
Copy link
Collaborator

fixes #780

@adietish
Copy link
Collaborator

@sbouchet: i tried to find a solution for the kotlin incompatibility reported for IC-2022.3. It looks to me as if bumping sinceVersion to 2023.1 would solve this. Bumping would be a no-brainer since 23.1 is 1.5y behind current.

@adietish
Copy link
Collaborator

Here's another suggestion: Could we add @AlexanderBartash as co-author to give him credits for the important help he gave?

@adietish
Copy link
Collaborator

@sbouchet:

Here's another suggestion: Could we add @AlexanderBartash as co-author to give him credits for the important help he gave?

Added his solution, adding @AlexanderBartov as author in the PR for the support of multi-kubeconfigs: 9f99cd6

@sbouchet
Copy link
Collaborator Author

Here's another suggestion: Could we add @AlexanderBartash as co-author to give him credits for the important help he gave?

Unfortunately forced push my branch and lost contribution from @AlexanderBartash :(

@AlexanderBartash
Copy link

Here's another suggestion: Could we add @AlexanderBartash as co-author to give him credits for the important help he gave?

Unfortunately forced push my branch and lost contribution from @AlexanderBartash :(

Do not mind it.

@adietish adietish force-pushed the issue-780 branch 2 times, most recently from 714b309 to 788b534 Compare October 24, 2024 12:59
@adietish adietish mentioned this pull request Oct 25, 2024
Merged
@sbouchet @adietish
chore: migrate build to 2024.2
34bfe04 
* bumping minimal version to 2023.1
* updated commons to 1.9.7-snapshot and use workaround provided by @AlexanderBartash
* removed @NonNls which caused errors in IC-2023.2

Signed-off-by: Andre Dietisheim <[email protected]>
Co-authored-by: @AlexanderBartash
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adietish adietish self-requested a review October 25, 2024 15:27
adietish
adietish approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adietish adietish merged commit 9ee07fa into redhat-developer:main Oct 25, 2024
12 checks passed
@sbouchet sbouchet deleted the issue-780 branch October 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adietish adietish adietish approved these changes

Assignees

@sbouchet sbouchet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support building against 2024.2
3 participants
@sbouchet @adietish @AlexanderBartash