Syncing latest changes from upstream master for rook #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing OSD migration process is limited to updating the OSD backend store. This docs proposes a more generic API for the OSD migration that will help with other scenarios as well. Signed-off-by: Santosh Pillai <[email protected]>
If the mon failover is in progress, ensure the removal of an extra mon deployment is skipped since that code path only has one mon in the list for the mon that was just newly started. The extra mon was erroneously removing a random mon in that case, followed immediately by the mon failover completing and removing the expected failed mon, and potentially causing mon quroum loss. Signed-off-by: Travis Nielsen <[email protected]>
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@aaa42aa...971e284) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.9 to 3.26.11. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@461ef6c...6db8d63) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [golang/govulncheck-action](https://github.com/golang/govulncheck-action) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/golang/govulncheck-action/releases) - [Commits](golang/govulncheck-action@dd0578b...b625fbe) --- updated-dependencies: - dependency-name: golang/govulncheck-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
mon: Do not remove extra mon in middle of failover
…angci/golangci-lint-action-6.1.1 build(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1
This step consumes several minutes per job. Signed-off-by: Joshua Hoblitt <[email protected]>
…hub/codeql-action-3.26.11 build(deps): bump github/codeql-action from 3.26.9 to 3.26.11
…ang/govulncheck-action-1.0.4 build(deps): bump golang/govulncheck-action from 1.0.3 to 1.0.4
test: rm canary/integration "Free Disk Space" step
doc: osd migration design
Do not force delete resources in validation cleanup. Force deletion can result in CNI IP address management (IPAM) addresses not being released cleanly, exhausting them. This can then lead to Rook cluster deploy failure if the CNI IPAM isn't able to garbage collect the IPs quickly. Signed-off-by: Blaine Gardner <[email protected]>
…-force-delete multus: do not force delete in validation cleanup
travisn
approved these changes
Oct 10, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch