Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] Bug 2244609: external: honour support of cluster-name legacy flag #735

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #554

/assign parth-gr

we have changed the --cluster-name flag to --k8s-cluster-name
but to support automation while upgrade we should support
the legacy flag

Signed-off-by: parth-gr <[email protected]>
(cherry picked from commit 8e4ec01)
Signed-off-by: parth-gr <[email protected]>
Copy link

openshift-ci bot commented Sep 27, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: parth-gr.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #554

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@parth-gr
Copy link
Member

/assign @travisn

Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parth-gr These changes are only needed in 4.14? Or do we need this fix in newer branches?
Are the CI failures all unrelated?

@parth-gr
Copy link
Member

@parth-gr These changes are only needed in 4.14? Or do we need this fix in newer branches? Are the CI failures all unrelated?

we have the fix in 4,15 and more,

CI failure would be totally unreleated

@travisn
Copy link

travisn commented Sep 27, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@travisn travisn merged commit e5d9d76 into red-hat-storage:release-4.14 Sep 27, 2024
16 of 46 checks passed
Copy link

openshift-ci bot commented Sep 27, 2024

@openshift-cherrypick-robot: Bugzilla bug 2244609 is in an unrecognized state (CLOSED (ERRATA)) and will not be moved to the MODIFIED state.

In response to this:

[release-4.14] Bug 2244609: external: honour support of cluster-name legacy flag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants