-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2313736: csi: fix the disable driver flag in the csi driver reconcile #734
Conversation
ROOK_CSI_DISABLE_DRIVER was not working accurate from rook#14489 The csi driver was installed even if its not expected Signed-off-by: parth-gr <[email protected]> (cherry picked from commit 166e4f3)
@parth-gr: This pull request references Bugzilla bug 2313736, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @travisn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parth-gr, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ROOK_CSI_DISABLE_DRIVER was not working accurate
from rook#14489
The csi driver was installed even if its not
expected
Signed-off-by: parth-gr [email protected]
(cherry picked from commit 166e4f3)
Checklist: