-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external: add a new configmap to store external cluster script #729
external: add a new configmap to store external cluster script #729
Conversation
add a new static configmap to store the external cluster script and ship it as part of the rook bundle Signed-off-by: Nikhil-Ladha <[email protected]>
add generated configmap changes Signed-off-by: Nikhil-Ladha <[email protected]>
cc @parth-gr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ensure the Rook CI will fail a gen-csv check so when the auto-sync PRs update the branch, we can detect when this needs to be refreshed.
We already have this check introduced when we created a separate CSV/bundle for rook long back. |
@@ -6,3 +6,4 @@ resources: | |||
- common.yaml | |||
- operator-openshift.yaml | |||
- csi/nfs/rbac.yaml | |||
- external-cluster-script-configmap.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested the csv is actually creating cm in the cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just tested it out. The cm is getting created when the rook bundle is installed on the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the result in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikhil_ladha@nladha ~ % oc get csv
NAME DISPLAY VERSION REPLACES PHASE
rook-ceph-operator.v4.17.0 Rook-Ceph 4.17.0 Succeeded
nikhil_ladha@nladha ~ % oc get pods
NAME READY STATUS RESTARTS AGE
0b7f16e6bac1a7b476544fbc3b65ccb25224106192898231caa871d2bdwb9kc 0/1 Completed 0 9m31s
quay-io-nladha-rook-ceph-operator-bundle-external 1/1 Running 0 9m40s
rook-ceph-operator-6b9b56c958-k5qv7 1/1 Running 3 (96s ago) 8m50s
nikhil_ladha@nladha ~ % oc get cm
NAME DATA AGE
0b7f16e6bac1a7b476544fbc3b65ccb25224106192898231caa871d2bdab5b7 22 9m37s
kube-root-ca.crt 1 79m
ocs-operator-config 7 8m10s
openshift-service-ca.crt 1 79m
rook-ceph-external-cluster-script-config 1 9m14s
rook-ceph-operator-catalog-configmap-partition-1 1 9m47s
@parth-gr: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
@parth-gr: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@travisn if everything looks good can we merge this PR? |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nikhil-Ladha, parth-gr, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a new static configmap to store the external cluster script and ship it as part of the rook bundle.