Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2308446:[release-4.17] Fix csv-gen script to correctly replace ROOK_IMAGE env var #719

Conversation

Nikhil-Ladha
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha commented Sep 4, 2024

This is a manual backport of #718
Also, updated the rook image as per 4.17 release.

updated csv-gen script to correctly replace ROOK_IMAGE
env var. Also, updated the rook image to the latest 1.15 tag.

Signed-off-by: Nikhil-Ladha <[email protected]>
add generated csv changes

Signed-off-by: Nikhil-Ladha <[email protected]>
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 4, 2024
Copy link

openshift-ci bot commented Sep 4, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2308446, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @dahorak

In response to this:

Bug 2308446:[release-4.17] Fix csv-gen script to correctly replace ROOK_IMAGE env var

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 4, 2024
Copy link

openshift-ci bot commented Sep 4, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: dahorak.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Nikhil-Ladha: This pull request references Bugzilla bug 2308446, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @dahorak

In response to this:

Bug 2308446:[release-4.17] Fix csv-gen script to correctly replace ROOK_IMAGE env var

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 4, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2308446, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @dahorak

In response to this:

Bug 2308446:[release-4.17] Fix csv-gen script to correctly replace ROOK_IMAGE env var

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 4, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: dahorak.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Nikhil-Ladha: This pull request references Bugzilla bug 2308446, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @dahorak

In response to this:

Bug 2308446:[release-4.17] Fix csv-gen script to correctly replace ROOK_IMAGE env var

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@subhamkrai
Copy link

/lgtm

@subhamkrai subhamkrai added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Nikhil-Ladha, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit acb3979 into red-hat-storage:release-4.17 Sep 4, 2024
51 checks passed
Copy link

openshift-ci bot commented Sep 4, 2024

@Nikhil-Ladha: All pull requests linked via external trackers have merged:

Bugzilla bug 2308446 has been moved to the MODIFIED state.

In response to this:

Bug 2308446:[release-4.17] Fix csv-gen script to correctly replace ROOK_IMAGE env var

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants