Syncing latest changes from upstream master for rook #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the github-dependencies group with 3 updates: [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph), [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) and [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator). Updates `github.com/ceph/go-ceph` from 0.28.0 to 0.29.0 - [Release notes](https://github.com/ceph/go-ceph/releases) - [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md) - [Commits](ceph/[email protected]) Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.75.2 to 0.76.0 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/[email protected]) Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.75.2 to 0.76.0 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/[email protected]) --- updated-dependencies: - dependency-name: github.com/ceph/go-ceph dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies ... Signed-off-by: subhamkrai <[email protected]>
build(deps): bump the github-dependencies group with 3 updates
The docker.io image prefix is expected to be prepended to the image names in the test images. This was missed in 14550 related to some CI tests, which was now causing the CI failures in the 1.15 branch where the search and replace was missing the new docker.io prefix. Signed-off-by: Travis Nielsen <[email protected]> (cherry picked from commit 3045076)
currently we created a new config file or user creation, Which was have the user config. We were also appending the script deafult values to the config file With that all the boolean values were appended to the config.ini file v2-port-enable = False .... But the config.ini treat all the bolean values as true, irrespective of they are set to, it is because the boolean cli flag doesnt accept the argument So now removed all the false values from the config.ini Signed-off-by: parth-gr <[email protected]>
build: Generate the local build tag with docker io
external: remove the false bool values from config file
The default service account isn't passed to the multus validation test when no config file is used. Fix this. Signed-off-by: Blaine Gardner <[email protected]>
Cleanup job cli was not reading the flags correctly. As a result, dataDirHostPath was never cleaned up. Signed-off-by: sp98 <[email protected]>
…st-default-service-account multus: fix default service account handling
core: fix host cleanup jobs to read flags correctly.
Use os.TempDir() instead of '/tmp'. This is for the peermap tests. Signed-off-by: chanyoung <[email protected]>
Previously, Rook would fail to create monitors for a `CephCluster` spec that
required them to be located in distinct failure domains:
```yaml
spec:
mon:
count: 3
failureDomainLabel: topology.kubernetes.io/zone
zones:
- eu-central-1a
- eu-central-1b
- eu-central-1c
```
This was due to the fact that Rook was mistakenly getting the
`failureDomainLabel` from `spec.mon.stretchCluster.failureDomainLabel`.
This commit ensures `spec.mon.failureDomainLabel` is being used instead, which
fixes the cluster deployment for the spec above.
Signed-off-by: Benoît Knecht <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
0112274
to
a305e25
Compare
…omainlabel core: fix Ceph monitor deployment in separate zones
tests: fix unit test failure on macOS due to temp directory path
df-build-team
force-pushed
the
sync_us--master
branch
from
a305e25
to
5f5c053
Compare
added 2 commits
August 25, 2024 04:04
…-master Signed-off-by: Ceph Jenkins <[email protected]>
add generated csv changes Signed-off-by: Ceph Jenkins <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
5f5c053
to
3d3a6fd
Compare
subhamkrai
approved these changes
Aug 26, 2024
subhamkrai
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch