-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from upstream master for rook #682
Conversation
This commit adds the flexibility to configure kube apiserver qps as per the user requirement and also keeps the existing values as the default one. Signed-off-by: yite.gu <[email protected]>
…rable csi: make kube apiserver qps configurable
the templateParam need to be updated with the right values before we are rendering the template. Signed-off-by: Madhu Rajanna <[email protected]>
csi: fix template render in logRotation
/lgtm |
@Madhu-1: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/unhold |
Let's just close this and wait for a fresh resync PR since #681 already merged one of these commits manually. The other change in this resync is not urgent. |
PR containing the latest commits from upstream master branch