Syncing latest changes from upstream master for rook #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed owner reference from Radosnamespace and subVolumeGroup cleanup resources. Signed-off-by: sp98 <[email protected]>
SVG cleanup job uses the cephSubvolumeGroup env name from spec.Name. But sometimes it can be empty. In that case rook should use the CR name. Signed-off-by: sp98 <[email protected]>
core: fix missing env in svg cleanup job
closes: rook#13214 Co-authored-by: Travis Nielsen <[email protected]> Co-authored-by: Blaine Gardner <[email protected]> Signed-off-by: Michael Adam <[email protected]>
core: remove owner refs in resource cleanup jobs
docs: document how to have StorageClass consume Rados Namespace
df-build-team
force-pushed
the
sync_us--master
branch
from
75180f4
to
3d62020
Compare
subhamkrai
approved these changes
May 21, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch