Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2257296: nfs: enable the rpc liveness probe in d/s 4.15 #553

Conversation

BlaineEXE
Copy link

In downstream, the RPC liveness probe is available in quincy (17.2.6) which is earlier than its availability upstream (18.2.1). Make a d/s-only patch to reflect this.

This is a similar tactic to what we used here: #551

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

In downstream, the RPC liveness probe is available in quincy (17.2.6)
which is earlier than its availability upstream (18.2.1). Make a
d/s-only patch to reflect this.

Signed-off-by: Blaine Gardner <[email protected]>
@BlaineEXE BlaineEXE requested a review from travisn January 8, 2024 19:27
Copy link

openshift-ci bot commented Jan 8, 2024

@BlaineEXE: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

nfs: enable the rpc liveness probe in d/s 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@BlaineEXE BlaineEXE changed the title nfs: enable the rpc liveness probe in d/s 4.15 Bug 2257296: nfs: enable the rpc liveness probe in d/s 4.15 Jan 8, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 8, 2024
Copy link

openshift-ci bot commented Jan 8, 2024

@BlaineEXE: This pull request references Bugzilla bug 2257296, which is invalid:

  • expected the bug to target the "ODF 4.15.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2257296: nfs: enable the rpc liveness probe in d/s 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BlaineEXE BlaineEXE marked this pull request as draft January 8, 2024 19:28
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@travisn
Copy link

travisn commented Jan 8, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BlaineEXE BlaineEXE marked this pull request as ready for review January 8, 2024 19:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@BlaineEXE BlaineEXE merged commit 2c7f55c into red-hat-storage:release-4.15 Jan 8, 2024
46 of 48 checks passed
@BlaineEXE BlaineEXE deleted the bz-2257296-force-enable-nfs-rpc-liveness-probe-odf-415 branch January 8, 2024 22:07
Copy link

openshift-ci bot commented Jan 8, 2024

@BlaineEXE: All pull requests linked via external trackers have merged:

Bugzilla bug 2257296 has been moved to the MODIFIED state.

In response to this:

Bug 2257296: nfs: enable the rpc liveness probe in d/s 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants