Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from release-1.13 for rook #544

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

df-build-team
Copy link

PR containing the latest commits from release-1.13 branch

sp98 and others added 4 commits December 6, 2023 18:20
This PR adds permissions to create or update k8s service by the
in the naemspaces other than rook operator namespace

Signed-off-by: sp98 <[email protected]>
(cherry picked from commit 1dea937)
core: ability to create, update and delete services in other namespaces (backport rook#13338)
This reverts commit 927af7c.

Signed-off-by: subhamkrai <[email protected]>
(cherry picked from commit a30338a)
Revert "osd: add callback function in osd removal" (backport rook#13349)
Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
Copy link

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@travisn travisn merged commit 890a206 into release-4.15 Dec 8, 2023
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants