Syncing latest changes from master for rook #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep the go dependencies minimal, add the go packages just for the pkg/apis directory. Projects that only reference the rook apis can then have a smaller footprint for Go dependencies. Signed-off-by: travisn <[email protected]>
Allow the flakiness threshold window to be tuned from the cli Signed-off-by: Sheetal Pamecha <[email protected]>
…test multus: improve the multus validation test's flakiness metric
build: Add go modules for apis subdir
|
/approve |
travisn
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Actually, we cannot merge this PR, we also need to include the fix from rook#13139. Closing this PR so that a new one can be opened with the new fix as well.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from master branch