Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2242433: osd: use bash script if restart interval is > 0 #528

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Bug 2242433: osd: use bash script if restart interval is > 0 #528

merged 1 commit into from
Oct 12, 2023

Conversation

sp98
Copy link

@sp98 sp98 commented Oct 12, 2023

If FlappingRestartIntervalHours for OSD is > 0 in the cephCluster CR, then start OSD inside a bash script.

Signed-off-by: sp98 [email protected]
(cherry picked from commit ffd6929)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

If `FlappingRestartIntervalHours` for OSD is > 0 in the cephCluster CR,
then start OSD inside a bash script.

Signed-off-by: sp98 <[email protected]>
(cherry picked from commit ffd6929)
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

osd: use bash script if restart interval is > 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title osd: use bash script if restart interval is > 0 Bug 2242433: osd: use bash script if restart interval is > 0 Oct 12, 2023
@travisn
Copy link

travisn commented Oct 12, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sp98, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travisn travisn merged commit ed872f1 into red-hat-storage:release-4.14 Oct 12, 2023
42 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants