Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2235395: core: return valid CIDR ip #515

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

subhamkrai
Copy link

we need to return a valid CIDR IP
to get it fenced properly, the previously
returned one was like 10.63.0.5:0/32 which
is not a valid CIDR, removing :0 to look like
proper IP CIDR.

Signed-off-by: Madhu Rajanna [email protected]
(cherry picked from commit eb304a5)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

we need to return a valid CIDR IP
to get it fenced properly, the previously
returned one was like `10.63.0.5:0/32` which
is not a valid CIDR, removing `:0` to look like
proper IP CIDR.

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit eb304a5)
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@subhamkrai: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

core: return valid CIDR ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai subhamkrai changed the title core: return valid CIDR ip Bug 2235395: core: return valid CIDR ip Aug 29, 2023
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@subhamkrai: This pull request references Bugzilla bug 2235395, which is invalid:

  • expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2235395: core: return valid CIDR ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai
Copy link
Author

@travisn ^^ cc @Madhu-1

@Madhu-1
Copy link
Member

Madhu-1 commented Aug 29, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@Madhu-1: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhu-1, subhamkrai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BlaineEXE BlaineEXE merged commit 194fd1e into red-hat-storage:release-4.14 Aug 29, 2023
43 of 45 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@subhamkrai: All pull requests linked via external trackers have merged:

Bugzilla bug 2235395 has been moved to the MODIFIED state.

In response to this:

Bug 2235395: core: return valid CIDR ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants