-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2233615: core: Operator skips reconcile of mons and osds in debug #512
Bug 2233615: core: Operator skips reconcile of mons and osds in debug #512
Conversation
During certain maintenance tasks the admin will own running operations on the ceph mons and osds, and the operator should not interfere with those operations. If the operator sees any mon in debug mode, every reconcile and mon health check will be skipped. Thus, mons will not be updated while any one of them is in maintenance. During OSD reconcile, individual OSD deployment updates will only be skipped for OSDs that are actively being debugged. The debug mode for osd and mon deployments is signaled by creating the ceph.rook.io/do-not-reconcile label. Signed-off-by: Travis Nielsen <[email protected]> (cherry picked from commit 7c56b93) (cherry picked from commit f34c940)
@travisn: Bugzilla bug 2233615 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@travisn , how about we do cherry-pick with -x from 10585 pr from rook?
I see these are the exact same changes but it helps in tracing things when something goes wrong, maybe it will not require this change but in general, good to follow.
I cherry-picked from rook#10690, which was the backport of 10585. What different approach are you suggesting? |
I don't see the cherry-pick comment we get when use |
Did you look on the commit page? I just usually delete it from the PR message. |
ah, missed that. |
@travisn need rebase? |
It's already on the latest. Are you wondering about the failing CI? I think the release-4.11 CI is just outdated and those are not related to the PR. |
yes, I was thinking was ci are failing but as you mentioned it could mainly due to older version |
@subhamkrai: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhamkrai, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ok thanks, i'll go ahead and merge. |
Description of your changes:
During certain maintenance tasks the admin will own running operations on the ceph mons and osds, and the operator should not interfere with those operations. If the operator sees any mon in debug mode, every reconcile and mon health check will be skipped. Thus, mons will not be updated while any one of them is in maintenance. During OSD reconcile, individual OSD deployment updates will only be skipped for OSDs that are actively being debugged.
The debug mode for osd and mon deployments is signaled by creating the ceph.rook.io/do-not-reconcile label.
Which issue is resolved by this Pull Request:
Resolves #https://bugzilla.redhat.com/show_bug.cgi?id=2233615
Checklist:
skip-ci
on the PR.