Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external: dont call telemetry if the cluster is external #496

Closed

Conversation

parth-gr
Copy link
Member

closes: rook#11470
Signed-off-by: parth-gr [email protected]
(cherry picked from commit a52e2f1)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

closes: rook#11470
Signed-off-by: parth-gr <[email protected]>
(cherry picked from commit a52e2f1)
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

@parth-gr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

external: dont call telemetry if the cluster is external

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parth-gr
Once this PR has been reviewed and has the lgtm label, please assign obnoxxx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travisn
Copy link

travisn commented Jul 10, 2023

@parth-gr Is there a BZ for this backport?

@parth-gr
Copy link
Member Author

@parth-gr Is there a BZ for this backport?

No @travisn Is this something good to have it,
For the 4.13 code it got auto committed by the branch,

Is a BZ needed so?

@travisn
Copy link

travisn commented Jul 10, 2023

For any downstream backport we need a BZ that is approved by PM/QE for merge. In this case, since the errors will just be seen in the operator log and can be ignored, customer impact is low so I don't think a backport is needed.

@parth-gr
Copy link
Member Author

Okay thanks for the feedback, closing

@parth-gr parth-gr closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants