Skip to content

Commit

Permalink
Merge pull request #708 from parth-gr/external-config-down
Browse files Browse the repository at this point in the history
Bug 2306577: external: remove the false bool values from config file
  • Loading branch information
travisn authored Aug 22, 2024
2 parents 3d25b9e + 82eac70 commit 8d5e9a9
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion deploy/examples/create-external-cluster-resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,12 @@ def getFinalUsedArgs(self):
# python treats flag-name as flag_name internally, so converting back to flag-name,
# so we can get those values from config file
argValue = arg.replace("_", "-")
if argValue != "config-file":
# do not add the config-file flag and also not add the boolean flags which are set to False
# because config.ini file treats boolean flags as True always
if (
argValue != "config-file"
and getattr(self._arg_parser, arg) != False
):
argument += f"{argValue} = {str(getattr(self._arg_parser, arg))}\n"
return argument

Expand Down

0 comments on commit 8d5e9a9

Please sign in to comment.