Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup + Bug fixes #1637

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

SanjalKatiyar
Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar commented Oct 14, 2024

https://issues.redhat.com/browse/RHSTOR-6568

Fixes for:

  • Try to navigate to buckets list page Route (by specifically typing in the URL) when deployed in "Full deployment" mode - Route works for MCG standalone, but page breaks for other modes, page should not break, even if other modes are not supported.
  • S3 commands and their types under shared should be defined in alphabetical order.
  • Add favourites option to the bucket overview header.
  • Add object/bucket count in the list page pagination, eg: "1 - 300 of many".
  • Add file/folder icons to objects list.
  • Pagination not working correctly.
Screenshot 2024-10-14 at 5 38 34 PM Screenshot 2024-10-14 at 6 37 19 PM

maxResponses: number
) => {
const fromCount = getFromCount(
continuationTokens,
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional comment:

Suggested change
continuationTokens,
continuationTokens.previous?.length || 0,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alright IMO, getFromCount will handle this...

@alfonsomthd
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,alfonsomthd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 001ef71 into red-hat-storage:master Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants