Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide In-transit Encryption checkbox when MCG deployment mode is selected #1617

Merged

Conversation

malayparida2000
Copy link
Contributor

@malayparida2000 malayparida2000 commented Oct 7, 2024

https://issues.redhat.com/browse/RHSTOR-6552

The encryption in transit option is based on Ceph’s MSGR v2 protocol and is meant for traffic interacting with & within the ceph cluster (client-osd, osd-osd). MCG is not covered by this, so it doesn't make sense to show the option when deployment mode is MCG Only.

The encryption in transit option is based on Ceph’s MSGR v2 protocol
and is meant for traffic interacting with & within the ceph cluster
(client-osd, osd-osd). MCG is not covered by this, so it doesn't make
sense to show the option when deployment mode is MCG Only.

Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000
Copy link
Contributor Author

Screenshot 2024-10-07 at 4 56 58 PM
Tested the changes in cluster, Checkbox is now hidden.

@SanjalKatiyar
Copy link
Collaborator

/approve

@openshift-ci openshift-ci bot added the approved label Oct 7, 2024
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, malayparida2000, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh
Copy link
Contributor

bipuladh commented Oct 8, 2024

/cherrypick release-4.17

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bipuladh
Copy link
Contributor

bipuladh commented Oct 8, 2024

/cherrpick release-4.17-compatibility

@openshift-merge-bot openshift-merge-bot bot merged commit 79087f7 into red-hat-storage:master Oct 8, 2024
5 checks passed
@openshift-cherrypick-robot

@bipuladh: new pull request created: #1618

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bipuladh
Copy link
Contributor

bipuladh commented Oct 8, 2024

/cherrypick release-4.17-compatibility

@openshift-cherrypick-robot

@bipuladh: new pull request created: #1621

In response to this:

/cherrypick release-4.17-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants