Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset radio button when Provider mode is selected from dropdown #1614

Merged

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Oct 4, 2024

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@alfonsomthd
Copy link
Collaborator

/lgtm

@alfonsomthd
Copy link
Collaborator

@bipuladh it seems there's a missing import.

@alfonsomthd
Copy link
Collaborator

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm label Oct 4, 2024
@SanjalKatiyar
Copy link
Collaborator

let's fix this as well, which was missed in the older PR for this BZ:

/odf/components/create-storage-system/create-storage-system-steps/backing-storage-step/backing-storage-step.tsx
  288:6  warning  React Hook React.useEffect has a missing dependency: 'isProviderModePresent'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

Copy link
Contributor

@GowthamShanmugam GowthamShanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanjalKatiyar
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh
Copy link
Contributor Author

bipuladh commented Oct 8, 2024

/cherrypick release-4.17

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bipuladh
Copy link
Contributor Author

bipuladh commented Oct 8, 2024

/cherrypick release-4.17-compatibility

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.17-compatibility in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6f69f2e into red-hat-storage:master Oct 8, 2024
5 checks passed
@openshift-cherrypick-robot

@bipuladh: new pull request created: #1622

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bipuladh: new pull request created: #1623

In response to this:

/cherrypick release-4.17-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants