Add object actions - create folder and delete object(s) #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanjalKatiyar
force-pushed
the
object_actions_delete
branch
4 times, most recently
from
63247a5
to
7b054c1
Compare
SanjalKatiyar
force-pushed
the
object_actions_delete
branch
from
7b054c1
to
83707a3
Compare
SanjalKatiyar
changed the title
SanjalKatiyar
requested review from
bipuladh,
alfonsomthd and
GowthamShanmugam
alfonsomthd
reviewed
Oct 8, 2024
locales/en/plugin__odf-console.json
Outdated
| @@ -1128,6 +1128,12 @@ | |||
| "Delete objects": "Delete objects", | |||
| "Actions": "Actions", | |||
| "Create folder": "Create folder", | |||
| "Failed to delete {{ count }} objects from the bucket. View deletion summary for details._one": "Failed to delete {{ count }} objects from the bucket. View deletion summary for details.", | |||
There was a problem hiding this comment.
For ._one shouldn't be the translation in singular?
Suggested change
| "Failed to delete {{ count }} objects from the bucket. View deletion summary for details._one": "Failed to delete {{ count }} objects from the bucket. View deletion summary for details.", | |
| "Failed to delete {{ count }} object from the bucket. View deletion summary for details._one": "Failed to delete {{ count }} objects from the bucket. View deletion summary for details.", |
alfonsomthd
reviewed
Oct 8, 2024
alfonsomthd
reviewed
Oct 8, 2024
| import * as _ from 'lodash-es'; | ||
| import { SearchInput, SearchInputProps } from '@patternfly/react-core'; | ||
|
|
||
| type TListFilter = { |
There was a problem hiding this comment.
AFAIK in this project we aren't prefixing types with T. we should be consistent and not mixing different coding guidelines.
There was a problem hiding this comment.
make sense...
alfonsomthd
reviewed
Oct 8, 2024
alfonsomthd
reviewed
Oct 8, 2024
SanjalKatiyar
force-pushed
the
object_actions_delete
branch
from
83707a3
to
a768cd0
Compare
|
/test odf-console-e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit cc59bbf
into
red-hat-storage:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHSTOR-6511
https://issues.redhat.com/browse/RHSTOR-6508