Add object actions - presigned URL, download and preview #1604
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| import { GetObjectCommandOutput } from '@aws-sdk/client-s3'; | ||
| import { S3Commands } from '@odf/shared/s3'; | ||
| import { getName } from '@odf/shared/selectors'; | ||
| import { ObjectCrFormat } from '../../../types'; | ||
|
|
||
| type DownloadAndPreviewFunction = ( | ||
| bucketName: string, | ||
| object: ObjectCrFormat, | ||
| noobaaS3: S3Commands, | ||
| setDownloadAndPreview: React.Dispatch< | ||
| React.SetStateAction<DownloadAndPreviewState> | ||
| > | ||
| ) => void; | ||
|
|
||
| type GetObjectURL = ( | ||
| bucketName: string, | ||
| object: ObjectCrFormat, | ||
| noobaaS3: S3Commands | ||
| ) => Promise<string>; | ||
|
|
||
| export type DownloadAndPreviewState = { | ||
| isDownloading: boolean; | ||
| isPreviewing: boolean; | ||
| }; | ||
|
|
||
| const getObjectURL: GetObjectURL = async (bucketName, object, noobaaS3) => { | ||
| const responseStream: GetObjectCommandOutput = await noobaaS3.getObject({ | ||
| Bucket: bucketName, | ||
| Key: getName(object), | ||
| }); | ||
| const blob = await new Response(responseStream.Body as ReadableStream).blob(); | ||
|
|
||
| return window.URL.createObjectURL(blob); | ||
| }; | ||
|
|
||
| export const onDownload: DownloadAndPreviewFunction = async ( | ||
| bucketName, | ||
| object, | ||
| noobaaS3, | ||
| setDownloadAndPreview | ||
| ) => { | ||
| try { | ||
| setDownloadAndPreview((downloadAndPreview) => ({ | ||
| ...downloadAndPreview, | ||
| isDownloading: true, | ||
| })); | ||
|
|
||
| const objectURL = await getObjectURL(bucketName, object, noobaaS3); | ||
|
|
||
| // create a download element and trigger download | ||
| const downloadLink = document.createElement('a'); | ||
| downloadLink.href = objectURL; | ||
| downloadLink.download = getName(object); | ||
| document.body.appendChild(downloadLink); | ||
| downloadLink.click(); | ||
| document.body.removeChild(downloadLink); | ||
|
|
||
| window.URL.revokeObjectURL(objectURL); | ||
| } catch (err) { | ||
| // eslint-disable-next-line no-console | ||
| console.error('Error fetching S3 object:', err); | ||
| } finally { | ||
| setDownloadAndPreview((downloadAndPreview) => ({ | ||
| ...downloadAndPreview, | ||
| isDownloading: false, | ||
| })); | ||
| } | ||
| }; | ||
|
|
||
| export const onPreview: DownloadAndPreviewFunction = async ( | ||
| bucketName, | ||
| object, | ||
| noobaaS3, | ||
| setDownloadAndPreview | ||
| ) => { | ||
| try { | ||
| setDownloadAndPreview((downloadAndPreview) => ({ | ||
| ...downloadAndPreview, | ||
| isPreviewing: true, | ||
| })); | ||
|
|
||
| const objectURL = await getObjectURL(bucketName, object, noobaaS3); | ||
|
|
||
| // open the object URL in a new browser tab | ||
| window.open(objectURL, '_blank'); | ||
| } catch (err) { | ||
| // eslint-disable-next-line no-console | ||
|
There was a problem hiding this comment. We can consider to allow There was a problem hiding this comment. make sense to me !! |
||
| console.error('Error fetching S3 object:', err); | ||
| } finally { | ||
| setDownloadAndPreview((downloadAndPreview) => ({ | ||
| ...downloadAndPreview, | ||
| isPreviewing: false, | ||
| })); | ||
| } | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason why we need this: https://stackoverflow.com/a/1214753
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luxon is a modern replacement for deprecated Moment.js