Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider mode: Set storage quota on storage clients #1466

Merged

Conversation

alfonsomthd
Copy link
Collaborator

@alfonsomthd alfonsomthd commented Jul 8, 2024

@alfonsomthd
Copy link
Collaborator Author

@Chandan141996 added screenshots.

@alfonsomthd alfonsomthd force-pushed the storage-quota branch 2 times, most recently from 835683c to 4a94a91 Compare July 8, 2024 12:44
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@SanjalKatiyar
Copy link
Collaborator

/approve cancel
cc @bipuladh for approval.

@openshift-ci openshift-ci bot removed the approved label Jul 11, 2024
@bipuladh
Copy link
Contributor

/approve
/lgtm

@alfonsomthd
Copy link
Collaborator Author

/hold

@alfonsomthd alfonsomthd force-pushed the storage-quota branch 2 times, most recently from 2ed1050 to 563ba5e Compare July 16, 2024 12:45
@Chandan141996
Copy link

  1. Please add the word "cluster" after "client" in the description for Unlimited storage quota.
  2. If it's not too late, I would recommend using the text box component instead of a custom box for the generated token. Currently, the custom box doesn't scale well and causes the modal to extend beyond its default margin. The text box component is scalable/scrollable. https://www.patternfly.org/components/forms/text-area#vertically-resizable

@alfonsomthd

@alfonsomthd
Copy link
Collaborator Author

  1. Please add the word "cluster" after "client" in the description for Unlimited storage quota.
  2. If it's not too late, I would recommend using the text box component instead of a custom box for the generated token. Currently, the custom box doesn't scale well and causes the modal to extend beyond its default margin. The text box component is scalable/scrollable. https://www.patternfly.org/components/forms/text-area#vertically-resizable

@alfonsomthd

@Chandan141996 Done.

Signed-off-by: Alfonso Martínez <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alfonsomthd
Copy link
Collaborator Author

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit 0e9237a into red-hat-storage:master Jul 18, 2024
5 checks passed
@alfonsomthd alfonsomthd deleted the storage-quota branch October 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants