Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove healthchecker ceph client #2838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove healthchecker ceph client #2838

wants to merge 1 commit into from

Conversation

ezio-auditore
Copy link
Contributor

Solves: #2829

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ezio-auditore
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ezio-auditore
Copy link
Contributor Author

/test all

@ezio-auditore
Copy link
Contributor Author

/test verify generated changes (1.22)

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@ezio-auditore: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-bundle-ocs-operator-bundle
  • /test images
  • /test ocs-operator-bundle-e2e-aws

Use /test all to run all jobs.

In response to this:

/test verify generated changes (1.22)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ezio-auditore ezio-auditore marked this pull request as ready for review October 3, 2024 14:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2024
@ezio-auditore
Copy link
Contributor Author

/assign @Madhu-1

@ezio-auditore
Copy link
Contributor Author

/hold for testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@ezio-auditore
Copy link
Contributor Author

/unhold verified

@ezio-auditore
Copy link
Contributor Author

/test ocs-operator-bundle-e2e-aws

@ezio-auditore
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@rewantsoni
Copy link
Member

The changes look good, just wondering if we should update the name for setCephResourceStatus method and CephResources field in the StorageConsumer Status to reflect that they can be any kind of Resources (NoobaaAccount or any other fields we might want to add in future)

Madhu-1
Madhu-1 reviewed Oct 8, 2024
View reviewed changes
controllers/storageconsumer/consumer_test.go Outdated
@@ -179,18 +147,13 @@ func TestCephName(t *testing.T) {
{
Kind: "CephClient",
Name: "rbd",
Phase: "Error",
Phase: "Ready",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have only Noobaa in the status nothing else, right? why do we have ceph clients in the status field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all cephclients

Remove healthchecker ceph client
a974162 
Signed-off-by: Kaustav Majumder <[email protected]>
@ezio-auditore
Copy link
Contributor Author

The changes look good, just wondering if we should update the name for setCephResourceStatus method and CephResources field in the StorageConsumer Status to reflect that they can be any kind of Resources (NoobaaAccount or any other fields we might want to add in future)

@rewantsoni Yes I agree the name should be changed from CephResources to GenericResources or some other name to clearly justify the need and the purpose of the field.

@ezio-auditore
Copy link
Contributor Author

/test ocs-operator-bundle-e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@ezio-auditore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocs-operator-bundle-e2e-aws a974162 link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Madhu-1
Madhu-1 reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Madhu-1
Copy link
Member

Madhu-1 commented Oct 14, 2024

The changes look good, just wondering if we should update the name for setCephResourceStatus method and CephResources field in the StorageConsumer Status to reflect that they can be any kind of Resources (NoobaaAccount or any other fields we might want to add in future)

@rewantsoni Yes I agree the name should be changed from CephResources to GenericResources or some other name to clearly justify the need and the purpose of the field.

This might need API change as API is tied to the CephResource name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 left review comments

@rewantsoni rewantsoni Awaiting requested review from rewantsoni

At least 2 approving reviews are required to merge this pull request.

Assignees

@Madhu-1 Madhu-1

@rewantsoni rewantsoni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezio-auditore @rewantsoni @Madhu-1