Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a default backing store for noobaa acount #2832

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Oct 2, 2024

noobaa account creation requires a default backing store to be specified which will be used to create new buckets for connected clients.

@leelavg
Copy link
Contributor Author

leelavg commented Oct 2, 2024

as this is a blocker for current release we are hardcoding the name of the default backing store which is tested manually and solves the issue. This has to be replaced w/ runtime finding of name.

@leelavg
Copy link
Contributor Author

leelavg commented Oct 2, 2024

/cherrypick release-4.17
https://bugzilla.redhat.com/show_bug.cgi?id=2314200

@openshift-cherrypick-robot

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17
https://bugzilla.redhat.com/show_bug.cgi?id=2314200

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ezio-auditore
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

@leelavg
Copy link
Contributor Author

leelavg commented Oct 2, 2024

/retest-required

@rewantsoni
Copy link
Member

@leelavg shouldn't we also watch the Noobaa account here?

noobaa account creation requires a default backing store to be specified
which will be used to create new buckets for connected clients.

Signed-off-by: Leela Venkaiah G <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2024
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f80f43b into red-hat-storage:main Oct 3, 2024
11 checks passed
@openshift-cherrypick-robot

@leelavg: new pull request created: #2834

In response to this:

/cherrypick release-4.17
https://bugzilla.redhat.com/show_bug.cgi?id=2314200

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants