Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding StorageQuotaUtilizationRatio field for storage consumer api #2697

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Adding StorageQuotaUtilizationRatio field for storage consumer api #2697

merged 1 commit into from
Oct 8, 2024

Conversation

rchikatw
Copy link
Contributor

@rchikatw rchikatw commented Jul 15, 2024 •
edited
Loading

  • This field will be useful in showing the Storage quota utilization of client in the UI
  • Value for this will be set from status section of cluster resource quota resource of client
status:
  total:
    used:
      requests.storage: 15Gi
  • status reporter is responsible for setting the value for StorageQuotaUtilization field

@rchikatw rchikatw force-pushed the addspecstorageconsumer branch 2 times, most recently from 394e57b to 97f3068 Compare July 15, 2024 11:13
@rchikatw rchikatw changed the title Adding usedCapacity for storage consumer api [WIP]Adding usedCapacity for storage consumer api Jul 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@rchikatw rchikatw force-pushed the addspecstorageconsumer branch 2 times, most recently from 58d1378 to 1835a4e Compare July 16, 2024 06:09
@rchikatw rchikatw changed the title [WIP]Adding usedCapacity for storage consumer api Adding usedCapacity for storage consumer api Jul 16, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@rchikatw
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2024
@rchikatw rchikatw changed the title Adding usedCapacity for storage consumer api [WIP] Adding usedCapacity for storage consumer api Jul 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2024
@rchikatw
Copy link
Contributor Author

rchikatw commented Sep 2, 2024

/hold

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
@rchikatw rchikatw changed the title [WIP] Adding usedCapacity for storage consumer api Adding usedCapacity for storage consumer api Sep 25, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@rchikatw
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
@rchikatw
Copy link
Contributor Author

@nb-ohad can i get review on this.

@rchikatw rchikatw force-pushed the addspecstorageconsumer branch 2 times, most recently from 90eec22 to a8ee5b6 Compare October 3, 2024 13:00
@rchikatw rchikatw changed the title Adding usedCapacity for storage consumer api Adding StorageQuotaUtilization field for storage consumer api Oct 3, 2024
@rchikatw rchikatw changed the title Adding StorageQuotaUtilization field for storage consumer api Adding StorageQuotaUtilizationRatio field for storage consumer api Oct 8, 2024
nb-ohad
nb-ohad requested changes Oct 8, 2024
View reviewed changes
api/v1alpha1/storageconsumer_types.go Outdated Show resolved Hide resolved
services/provider/api/interfaces/interfaces.go Outdated Show resolved Hide resolved
services/provider/api/interfaces/interfaces.go Outdated Show resolved Hide resolved
services/provider/proto/provider.proto Outdated Show resolved Hide resolved
@nb-ohad
Copy link
Contributor

nb-ohad commented Oct 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rchikatw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0b8482e into red-hat-storage:main Oct 8, 2024
11 checks passed
@rchikatw rchikatw mentioned this pull request Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg left review comments

@bipuladh bipuladh bipuladh left review comments

@nb-ohad nb-ohad nb-ohad requested changes

Assignees

@nb-ohad nb-ohad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rchikatw @nb-ohad @leelavg @bipuladh @openshift-merge-robot