Skip to content

Update the Prometheus rule alerts acc to specified value & correct the default values in API desc #4851

Update the Prometheus rule alerts acc to specified value & correct the default values in API desc

Update the Prometheus rule alerts acc to specified value & correct the default values in API desc #4851

Triggered via pull request September 24, 2024 11:29
Status Failure
Total duration 1m 45s
Artifacts

ocs-operator-ci.yaml

on: pull_request
shellcheck
15s
shellcheck
verify code spellings
13s
verify code spellings
commitlint
18s
commitlint
Matrix: go test
Matrix: golangci-lint
Matrix: verify generated changes
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 2 warnings
commitlint
You have commit messages with errors ⧗ input: Move default full ratios configuration to cephCluster CR from override CM Till now the default ceph full ratios for ODF were being set in the rook-config-override ConfigMap. As we have now exposed the settings for the ratios in the storageCLuster CR and they are being passed onto the cephCluster CR, it's good to integrate the default value applying to this flow too. Also currently there is no singular source for the default values of full ratios, this could create future confusion and hence it is better to have them at a single place inside the default package. Signed-off-by: Malay Kumar Parida <[email protected]> ✖ header must not be longer than 72 characters, current length is 73 [header-max-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
golangci-lint (1.22): controllers/storagecluster/cephcluster_test.go#L1674
tests: TestgetFullRatios has malformed name: first letter after 'Test' must not be lowercase (govet)
golangci-lint (1.22)
issues found
verify generated changes (1.22)
Process completed with exit code 2.
verify generated changes (1.22)
Restore cache failed: Dependencies file is not found in /home/runner/work/ocs-operator/ocs-operator. Supported file pattern: go.sum
go test (1.22)
Restore cache failed: Dependencies file is not found in /home/runner/work/ocs-operator/ocs-operator. Supported file pattern: go.sum