WIP: Added onboarding token generation related functional tests for provider-client feature #9938

amr1ta · 2024-06-12T14:11:07Z

Added onboarding token generation related functional tests for provider-client feature

jilju · 2024-06-14T10:17:55Z

tests/functional/provider_client/test_onboarding_token_generation.py

+
+
+@tier1
+@green_squad


This is not a green squad test. May be yellow squad ?

Have updated in latest commit.

jilju · 2024-06-14T10:20:10Z

tests/functional/provider_client/test_onboarding_token_generation.py

+    @pytest.fixture(autouse=True)
+    def setup(self, request):
+        """
+        Resetting the default value of KeyRotation


Any code missing in this method for resetting?

Addressed in latest commit.

jilju · 2024-06-14T10:21:03Z

tests/functional/provider_client/test_onboarding_token_generation.py

+        Test to verify the respin of ux pod.
+        Steps:


Suggested change

Test to verify the respin of ux pod.

Steps:

Test to verify the respin of ux pod.

Steps:

Addressed in latest commit.

jilju · 2024-06-14T10:25:15Z

tests/functional/provider_client/test_onboarding_token_generation.py

+            timeout=180,
+        ), "ux pod is not in running state as expected"
+
+    def test_respin_of_ux_server_pod(self):


This is a tier4c test. Please add marker in the test case level for all test cases.

Addressed in latest commit.

jilju · 2024-06-14T10:26:04Z

tests/functional/provider_client/test_onboarding_token_generation.py

+            selector=constants.UX_BACKEND_SERVER_LABEL,
+            resource_count=1,
+            timeout=180,
+        ), "ux pod is not in running state as expected"


Suggested change

), "ux pod is not in running state as expected"

), "ux-backend-server pod is not in running state as expected"

Addressed in latest commit.

jilju · 2024-06-14T10:29:16Z

tests/functional/provider_client/test_onboarding_token_generation.py

+        """
+        Test to verify the respin of ux pod.
+        Steps:
+            1. navigate to storage-->storage clients page


Please mention the step of deleting the ux-backend-server pod.

Addressed in latest commit.

jilju · 2024-06-14T10:31:01Z

tests/functional/provider_client/test_onboarding_token_generation.py

+
+        ux_pod_obj.delete()
+        log.info("wait some time for another ux-backend-server pod to come up")
+        time.sleep(30)


The new pod will come up in 3-5 seconds. Please remove sleep for short period and use wait conditions for checking the new pod.

Addressed in latest commit.

jilju · 2024-06-14T10:36:02Z

tests/functional/provider_client/test_onboarding_token_generation.py

+            timeout=180,
+        ), "ux pod is not in running state as expected"
+
+    def test_respin_of_ux_server_pod(self):


I think a separate test case to check the re-spin of pod is not needed. This will be part of tier4c pod re-spin tests. Please combine the test with test_onboarding_token_generation_option_is_available_in_ui(and change the name of test) to verify the impact of ux pod respin on token generation.

I have combined the test to check ux-backend-server pod is urunning and ux-backend-server pod respin testcases together.

ebondare · 2024-06-17T09:05:22Z

Could you please include a test run?

DanielOsypenko · 2024-09-25T12:04:08Z

tests/functional/provider_client/test_onboarding_token_generation.py

+        assert HostedODF(cluster_name).get_storage_client_status() == "Connected"
+
+        log.info("Destroy hosted cluster")
+        assert destroy_hosted_cluster(cluster_name), "Failed to destroy hosted cluster"


fyi destroy_hosted_cluster will leave leftovers, ceph resources on provider.
Lets add this to the docstring of the test?

DanielOsypenko · 2024-09-25T12:05:30Z

tests/functional/provider_client/test_onboarding_token_generation.py

+        ), f"Failed to switch to cluster '{cluster_name}' and fetch data"
+
+        log.info("Test create onboarding key")
+        HostedClients().download_hosted_clusters_kubeconfig_files()


self.download_hosted_clusters_kubeconfig_files() already happened at HostedClients.do_deploy, you can remove this line

DanielOsypenko · 2024-09-25T12:09:37Z

tests/functional/provider_client/test_onboarding_token_generation.py

+        )
+        ux_pod_obj = pod.Pod(**ux_pod[0])
+        log.info("ux backed server pod respinned")
+        assert pod.validate_pods_are_respinned_and_running_state([ux_pod_obj])


pls add string with failure context

DanielOsypenko · 2024-09-25T12:10:29Z

tests/functional/provider_client/test_onboarding_token_generation.py

+            4. user can generate onboarding token by selecting this option.
+        """
+        secret_ocp_obj = ocp.OCP(
+            kind=constants.SECRET, namespace=constants.OPENSHIFT_STORAGE_NAMESPACE


we need to use config.ENV_DATA['cluster_namespace'] instead of constant constants.OPENSHIFT_STORAGE_NAMESPACE

DanielOsypenko · 2024-09-25T12:13:04Z

ocs_ci/ocs/ui/validation_ui.py

+            ).is_selected(), "Default value unlimited quota is not selected"
+
+            # Take screenshot
+            self.take_screenshot()


pls use description param, this way we will identify screenshot by name in the UI logs dir
something like
self.take_screenshot("verify_storage_clients_page")

DanielOsypenko · 2024-09-25T12:16:53Z

ocs_ci/ocs/ui/base_ui.py

-            acm_page["all-clusters_dropdown_item"]
-        )
-        all_clusters_item.click()
+        if not not find_element:


due to implementation of wait_for_element_to_be_visible, it will fail if element not found.
The if not not find_element will not work.

Also "not" has been used 2 times

def wait_for_element_to_be_visible(locator, timeout=30): """ Wait for element to be visible. Use when Web element is not have to be clickable (icons, disabled btns, etc.) Method does not fail when Web element not found Args: locator (tuple): (GUI element needs to operate on (str), type (By)). timeout (int): Looks for a web element until timeout (sec) occurs Returns: selenium.webdriver.remote.webelement.WebElement: Visible web element. """ wait = WebDriverWait(SeleniumDriver(), timeout) try: web_element = wait.until( ec.visibility_of_element_located((locator[1], locator[0])) ) except TimeoutException: take_screenshot() copy_dom() raise return web_element

…er-client feature Signed-off-by: Amrita Mahapatra <[email protected]>

Signed-off-by: Amrita Mahapatra <[email protected]>

…client from the hosted cluster Signed-off-by: Amrita Mahapatra <[email protected]>

Signed-off-by: Amrita Mahapatra <[email protected]>

…oken with limited storage quota Signed-off-by: Amrita Mahapatra <[email protected]>

Signed-off-by: Amrita Mahapatra <[email protected]>

…timeout for local-cluster load Signed-off-by: Amrita Mahapatra <[email protected]>

Signed-off-by: Amrita Mahapatra <[email protected]>

…own' locator in navigate_to_local_cluster method Signed-off-by: Amrita Mahapatra <[email protected]>

Signed-off-by: Amrita Mahapatra <[email protected]>

…_rpm_package method Signed-off-by: Amrita Mahapatra <[email protected]>

Signed-off-by: Amrita Mahapatra <[email protected]>

amr1ta requested review from a team as code owners June 12, 2024 14:11

pull-request-size bot added the size/L PR that changes 100-499 lines label Jun 12, 2024

amr1ta force-pushed the onboarding-token-generation-ui branch 14 times, most recently from cc42719 to 9020bb9 Compare June 13, 2024 16:29

jilju previously approved these changes Jun 14, 2024

View reviewed changes

openshift-ci bot assigned jilju Jun 14, 2024

openshift-ci bot added the lgtm label Jun 14, 2024

jilju self-requested a review June 14, 2024 10:38

jilju removed their assignment Jun 14, 2024

fbalak previously approved these changes Jun 14, 2024

View reviewed changes

openshift-ci bot assigned fbalak Jun 14, 2024

amr1ta dismissed stale reviews from fbalak and jilju via 5d81873 June 14, 2024 14:41

openshift-ci bot removed the lgtm label Jun 14, 2024

amr1ta force-pushed the onboarding-token-generation-ui branch from 5d81873 to 65e6515 Compare August 7, 2024 06:26

ebondare previously approved these changes Aug 13, 2024

View reviewed changes

DanielOsypenko reviewed Sep 25, 2024

View reviewed changes

amr1ta force-pushed the onboarding-token-generation-ui branch from 98a04e3 to 1cfa5e4 Compare October 7, 2024 08:56

amr1ta added 21 commits October 10, 2024 10:57

Added onboarding token generation related functional tests for provid…

28d6006

…er-client feature Signed-off-by: Amrita Mahapatra <[email protected]>

Updated ux pod respin testcase

cd8af17

Signed-off-by: Amrita Mahapatra <[email protected]>

Updated squad details

bfbc446

Signed-off-by: Amrita Mahapatra <[email protected]>

Addressed review comments

eeb8a6b

Signed-off-by: Amrita Mahapatra <[email protected]>

Added a testcase for creating a hosted cluster and onboarding storage…

b29e2f7

…client from the hosted cluster Signed-off-by: Amrita Mahapatra <[email protected]>

Updated with hci_provider_required fixture

cd3e561

Signed-off-by: Amrita Mahapatra <[email protected]>

Updated with create and destroy hypershift cluster fixtures

4b4d5ef

Signed-off-by: Amrita Mahapatra <[email protected]>

Added steps to validate default storage-quota and create onboarding t…

4c037a7

…oken with limited storage quota Signed-off-by: Amrita Mahapatra <[email protected]>

Corrected a typo

2dee783

Signed-off-by: Amrita Mahapatra <[email protected]>

Corrected a typo

726d965

Signed-off-by: Amrita Mahapatra <[email protected]>

removed duplicate import

f8441cc

Signed-off-by: Amrita Mahapatra <[email protected]>

Updated test

627caad

Signed-off-by: Amrita Mahapatra <[email protected]>

Updated test

7675f64

Signed-off-by: Amrita Mahapatra <[email protected]>

added sleep to let the dashboard load successfully and increaded the …

4f0e846

…timeout for local-cluster load Signed-off-by: Amrita Mahapatra <[email protected]>

added fixture for login and close browser

4de52ad

Signed-off-by: Amrita Mahapatra <[email protected]>

Updated 'local-cluster_dropdown_item' locator to 'local-cluster_dropd…

7413e27

…own' locator in navigate_to_local_cluster method Signed-off-by: Amrita Mahapatra <[email protected]>

Updated few locators of generate onboarding token page

b103e4c

Signed-off-by: Amrita Mahapatra <[email protected]>

updated navigate_to_all_clusters method

4c4957e

Signed-off-by: Amrita Mahapatra <[email protected]>

Added ignore leftover tag

a6d8498

Signed-off-by: Amrita Mahapatra <[email protected]>

Added retry in case of ResourceNotFoundError to collect_pod_container…

3a5c3f2

…_rpm_package method Signed-off-by: Amrita Mahapatra <[email protected]>

Imported locally to resolve circular import issue

0ef5608

Signed-off-by: Amrita Mahapatra <[email protected]>

amr1ta force-pushed the onboarding-token-generation-ui branch from 1cfa5e4 to 0ef5608 Compare October 10, 2024 05:35

Added parameter to accept storage_quota from config.env

f1da2f0

Signed-off-by: Amrita Mahapatra <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Added onboarding token generation related functional tests for provider-client feature #9938

WIP: Added onboarding token generation related functional tests for provider-client feature #9938

amr1ta commented Jun 12, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

jilju Jun 14, 2024

amr1ta Jun 14, 2024

ebondare commented Jun 17, 2024

DanielOsypenko Sep 25, 2024

DanielOsypenko Sep 25, 2024

DanielOsypenko Sep 25, 2024

DanielOsypenko Sep 25, 2024

DanielOsypenko Sep 25, 2024 •

edited

Loading

DanielOsypenko Sep 25, 2024

	), "ux pod is not in running state as expected"
	), "ux-backend-server pod is not in running state as expected"



		@tier1
		@green_squad

WIP: Added onboarding token generation related functional tests for provider-client feature #9938

Are you sure you want to change the base?

WIP: Added onboarding token generation related functional tests for provider-client feature #9938

Conversation

amr1ta commented Jun 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebondare commented Jun 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanielOsypenko Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanielOsypenko Sep 25, 2024 •

edited

Loading