Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PVKeyrotation tests failures #10628

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fixed PVKeyrotation tests failures #10628

merged 2 commits into from
Oct 9, 2024

Conversation

paraggit
Copy link
Contributor

@paraggit paraggit commented Oct 8, 2024

Fixed PVKeyrotation tests failures

@paraggit paraggit requested a review from a team as a code owner October 8, 2024 10:21
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Oct 8, 2024
shyRozen
shyRozen previously approved these changes Oct 8, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2024
ocs-ci
ocs-ci reviewed Oct 8, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pv/pv_encryption/test_pv_keyrotation.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@paraggit paraggit added the Verified Mark when PR was verified and log provided label Oct 8, 2024
nehaberry
nehaberry previously approved these changes Oct 9, 2024
View reviewed changes
@paraggit paraggit dismissed stale reviews from nehaberry and shyRozen via 97a87a8 October 9, 2024 05:43
@openshift-ci openshift-ci bot removed the lgtm label Oct 9, 2024
ocs-ci
ocs-ci reviewed Oct 9, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pv/pv_encryption/test_pv_keyrotation.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@paraggit paraggit requested a review from shyRozen October 9, 2024 09:19
@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, paraggit, shyRozen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit c2e8adc into red-hat-storage:master Oct 9, 2024
7 of 8 checks passed
nagendra202 pushed a commit to nagendra202/ocs-ci that referenced this pull request Oct 14, 2024
@paraggit @nagendra202
Fixed PVKeyrotation tests failures (red-hat-storage#10628)
938d5f6 
Signed-off-by: Parag Kamble <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ebenahar ebenahar ebenahar approved these changes

@shyRozen shyRozen shyRozen approved these changes

@nehaberry nehaberry Awaiting requested review from nehaberry

Assignees

@ebenahar ebenahar

@shyRozen shyRozen

@nehaberry nehaberry

Labels
lgtm size/S PR that changes 10-29 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paraggit @ebenahar @shyRozen @nehaberry @ocs-ci