Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flexibility to check capacity between ui and cli #10625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shyRozen
Copy link
Contributor

@shyRozen shyRozen commented Oct 8, 2024

The test is failing when one capacity is 313.5m and the other is 314m. Adding flexibility to tollerate ~1 difference.

@shyRozen shyRozen requested a review from a team as a code owner October 8, 2024 07:46
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Oct 8, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: srozen0-ipv6-acc
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: srozen0-ipv6-acc
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@DanielOsypenko
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Oct 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, shyRozen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S PR that changes 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants