Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable dr #10442

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

disable dr #10442

wants to merge 4 commits into from

Conversation

keemano
Copy link
Contributor

@keemano keemano commented Sep 9, 2024

This test

  1. Creates appset based and subscription based workload,
  2. Configures RDR
  3. Perform disable dr on it,
  4. Validate drpc deletion, vrg deletion, pods, pvc on primary cluster

@keemano keemano requested review from a team as code owners September 9, 2024 05:55
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Sep 9, 2024
am-agrawa
am-agrawa reviewed Oct 14, 2024
View reviewed changes
tests/functional/disaster-recovery/regional-dr/test_disable_dr.py
import logging
import pytest
from time import sleep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

tests/functional/disaster-recovery/regional-dr/test_disable_dr.py Show resolved Hide resolved
ebenahar
ebenahar reviewed Oct 14, 2024
View reviewed changes
ocs_ci/helpers/dr_helpers.py
@@ -1661,3 +1661,57 @@ def generate_kubeobject_capture_interval():
return 5
else:
return capture_interval


def disable_dr_rdr():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function has similarities to

ocs-ci/ocs_ci/helpers/dr_helpers.py

Line 1458 in 7686692

def disable_dr_from_app(secondary_cluster_name):
.
Can we merge them?

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, keemano

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebenahar ebenahar ebenahar left review comments

@sidhant-agrawal sidhant-agrawal sidhant-agrawal left review comments

@prsurve prsurve prsurve left review comments

@am-agrawa am-agrawa am-agrawa approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@am-agrawa am-agrawa

Labels
lgtm size/L PR that changes 100-499 lines Squad/Turquoise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keemano @ebenahar @sidhant-agrawal @prsurve @am-agrawa @openshift-merge-robot