-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download virtctl tool #10372
base: master
Are you sure you want to change the base?
Download virtctl tool #10372
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e904304
to
aab7f49
Compare
- separate getting asset from github to separated function fixes: red-hat-storage#10366 Signed-off-by: Daniel Horak <[email protected]>
aab7f49
to
3905c8a
Compare
- as a fallback download it from github - add fixture Signed-off-by: Daniel Horak <[email protected]>
@yitzhak12 I've updated/enhanced this PR in the way, that it firstly try to get the |
Verified locally with dummy tests:
|
This PR is adding new fixture to get virtctl tool. It checks if this tool is available and if not, it firstly try to get it from the CNV if installed on the cluster and as a fall-back it downloads it from upstream github repository.
Also separating getting asset from github to separated function and use it in the new
get_virtctl_tool
function and also inget_opm_tool
.fixes: #10366